シンプルな2ブール効率

Question

あなたの脳が何かを見ているだけで、すぐに素敵な人がいます。ブール論理の観点からこれを行う「より良い」方法があるかどうかを見てください。

private RegenerationType AccquireRegenerationState (int floor, int playerFloor) 
{ 
    bool entranceExists = (floorBlocks[floor].doorBlocks.Count != 0) ? true : false; 

    if (floor + 1 == playerFloor || !floorBlocks[floor + 1].isVisited) 
    { 
     if (entranceExists) 
     { 
      return RegenerationType.Still; 
     } 
     else 
     { 
      return RegenerationType.Limit; 
     } 
    } 
    else 
    { 
     if (entranceExists) 
     { 
      return RegenerationType.Prime; 
     } 
     else 
     { 
      return RegenerationType.Full; 
     } 
    } 
} 

Answer 1

私はあなたが達成できる最高のものだと思います。もちろん、あなたは、コードの読みやすさと鮮明さを維持すると仮定：

private RegenerationType AccquireRegenerationState (int floor, int playerFloor) 
{ 
    var entranceExists = floorBlocks[floor].doorBlocks.Count != 0; 

    var whatever = floor + 1 == playerFloor || !floorBlocks[floor + 1].isVisited; 

    if (whatever) 
    { 
     return entranceExists ? RegenerationType.Still : RegenerationType.Limit; 
    } 
    else 
    { 
     return entranceExists ? RegenerationType.Prime : RegenerationType.Full; 
    } 
} 

Answer 2

bool entranceExists = (floorBlocks[floor].doorBlocks.Count != 0); 
return 
    (floor + 1 == playerFloor || !floorBlocks[floor + 1].isVisited)? 
    (entranceExists? RegenerationType.Still: RegenerationType.Limit): 
    (entranceExists? RegenerationType.Prime: RegenerationType.Full);