関数内でafサブ関数を呼び出す際の問題

Question

私はグーグルで多くのことを行っていますが、私が間違っていることを理解することはできません。

Public Sub ConnectToBloomberg(Code) 

Dim sUrl As String 
Dim rawJson As Dictionary 
Dim pricedata As Object 
Dim dataRequest As WinHttp.WinHttpRequest 

sUrl = "http://www.bloomberg.com/markets/api/bulk-time-series/price/" & Code & "?timeFrame=1_YEAR" 

Set dataRequest = New WinHttp.WinHttpRequest 

With dataRequest 
    .Open "GET", sUrl, True 
    .Send 
    .WaitForResponse 
    FetchedData = .ResponseText 
End With 

FetchedData = Right(FetchedData, Len(FetchedData) - 1) 
FetchedData = Left(FetchedData, Len(FetchedData) - 1) 

Set Json = JsonConverter.ParseJson(FetchedData) 

Set pricedata = Json.Item("price") 

End Sub 

Function MEANVALUE() As Double 

ConnectToBloomberg (Code) 

For Each Item In pricedata 

    Count = Count + 1 

    YReturn = Item("value") - LastPrice 

    LastPrice = Item("value") 

    Total = Total + YReturn 

Next 

Mean = Total/Count 

MEANVALUE = Mean 

End Function 

問題は、私がSubを呼び出そうとする2番目の関数にあるはずです。

私はVBAのかなりのnoobieです！ :-)

私は間違っていますか？

ありがとうございます！

---

別の方法で説明します。

Function MEANVALUE(Code) As Double 

Dim sUrl As String 
Dim rawJson As Dictionary 
Dim pricedata As Object 
Dim dataRequest As WinHttp.WinHttpRequest 

sUrl = "http://www.bloomberg.com/markets/api/bulk-time-series/price/" & Code & "?timeFrame=1_YEAR" 

Set dataRequest = New WinHttp.WinHttpRequest 

With dataRequest 
    .Open "GET", sUrl, True 
    .Send 
    .WaitForResponse 
    FetchedData = .ResponseText 
End With 

FetchedData = Right(FetchedData, Len(FetchedData) - 1) 
FetchedData = Left(FetchedData, Len(FetchedData) - 1) 

Set Json = JsonConverter.ParseJson(FetchedData) 

Set pricedata = Json.Item("price") 

For Each Item In pricedata 

    Count = Count + 1 

    YReturn = Item("value") - LastPrice 

    LastPrice = Item("value") 

    Total = Total + YReturn 

Next 

Mean = Total/Count 

MEANVALUE = Mean 

End Function 

をしかし、私は他の関数でこのコードを使用しています：このコードは、実際に動作する

Dim sUrl As String 
Dim rawJson As Dictionary 
Dim pricedata As Object 
Dim dataRequest As WinHttp.WinHttpRequest 

sUrl = "http://www.bloomberg.com/markets/api/bulk-time-series/price/" & Code & "?timeFrame=1_YEAR" 

Set dataRequest = New WinHttp.WinHttpRequest 

With dataRequest 
    .Open "GET", sUrl, True 
    .Send 
    .WaitForResponse 
    FetchedData = .ResponseText 
End With 

FetchedData = Right(FetchedData, Len(FetchedData) - 1) 
FetchedData = Left(FetchedData, Len(FetchedData) - 1) 

Set Json = JsonConverter.ParseJson(FetchedData) 

Set pricedata = Json.Item("price") 

だから私は代わりに、各機能に手動でコードを使用するのではなく、それを呼び出すことができるようにしたいです。

Answer 1

現在のConnectToBloombergサブルーチンは実際には何も生産的ではありません。サブルーチンの終わりにはすべての計算が失われます。あなたはこの問題を解決する方法はいくつか持っている

：あなたのMEANVALUE機能があなたのConnectToBloombergサブルーチンとしてだけでなく、それをアクセスできるように

1. がpricedataモジュールレベルを作るには、変数をスコープ。代わりに、サブルーチンの（価格データを返す）Functionなるように変更ConnectToBloombergConnectToBloomberg
2. への呼び出しでパラメータを経由して
3. パスバックpricedata。以下は

第三のアプローチを使用していくつかのコードです：

Public Function ConnectToBloomberg(Code As String) As Object 

    Dim sUrl As String 
    Dim rawJson As Dictionary 
    Dim dataRequest As WinHttp.WinHttpRequest 
    Dim Json As Object 
    Dim FetchedData As String 

    sUrl = "http://www.bloomberg.com/markets/api/bulk-time-series/price/" & Code & "?timeFrame=1_YEAR" 

    Set dataRequest = New WinHttp.WinHttpRequest 

    With dataRequest 
     .Open "GET", sUrl, True 
     .Send 
     .WaitForResponse 
     FetchedData = .ResponseText 
    End With 

    FetchedData = Right(FetchedData, Len(FetchedData) - 1) 
    FetchedData = Left(FetchedData, Len(FetchedData) - 1) 

    Set Json = JsonConverter.ParseJson(FetchedData) 

    Set ConnectToBloomberg = Json.Item("price") 
End Sub 

Function MEANVALUE(Code As String) As Double 
    Dim pricedata As Object 
    Dim Item As Variant 
    Dim Count As Long 
    Dim YReturn As Double 
    Dim LastPrice As Double 
    Dim Total As Double 

    Set pricedata = ConnectToBloomberg(Code) 

    For Each Item In pricedata 
     Count = Count + 1 
     YReturn = Item("value") - LastPrice 
     LastPrice = Item("value") 
     Total = Total + YReturn 
    Next 
    If Count > 0 Then 
     MEANVALUE = Total/Count 
    Else 
     MEANVALUE = 0 
    End If 
End Function