価値の無限戻り値

Question

私はまだJavaにとって非常に新しいですし、ループに問題があります。

私はランダムな値を持つオブジェクトを作成しようとしています。 私は私のメインのメソッドを呼び出すとき、無限のオブジェクトを返します。私は1をヒットした場合、私はchoosePick

 import java.util.Scanner; 

     public class main_1vs1 { 

      public static void main(String[] args) { 

       Scanner sc = new Scanner(System.in); 


       int knight =0; 
       while(knight != 1 && knight !=2) { 

        System.out.println("which knight do you choose? Pick is fast (1), Crock is strong (2). " + "\n" + "Make your choice :" + "\n"); 
        knight = sc.nextInt(); 

       if (knight==1){ 
         knights.choosePick(); 
         break; 
        } 
       else if (knight==2){ 
         knights.chooseCrock(); 
         break; 
       } 

       } 
    } 
} 

を呼び出したい

public class knights{       

    public double health; 
    public weapons weapons; 
    public double speed; 

    public knights(double health,int weapons, double speed){   
     this.health = health; 
     this.weapons = new weapons(weapons); 
     this.speed = speed; 
    } 

    public static knights choosePick(){ 

      knights Pick = new knights((70 + (Math.random() * (130 - 70))),-1,(100 + (Math.random() * (150 - 100)))); 
      System.out.println("The knight Pick is equipped with " + Pick.weapons.type + ". Its damages are " +Pick.weapons.atk + " It has " + Pick.weapons.acc + " accuracy " + "\n" + "He has " + Pick.health + " Health points" + "\n" + "His speed is " + Pick.speed); 
      return choosePick(); 
    } 
} 

、それはknight.Pickの無限の量を作成し、スタットdescripitionの無限の量を表示します。

Answer 1

あなたの方法choosePickがreturn choosePick()で終わるので、あなたはそれはあなたがこれに達すると、単に

return Pick; 

Answer 2

でreturnを置き換え、それは無限のようにあなたがStackOverflowErrorで終わるであるように、自分自身を呼び出すことを意味し、この動作を取得声明knights.choosePick();は、あなたはここで再帰

public static knights choosePick(){ 

      knights Pick = new knights((70 + (Math.random() * (130 - 70))),-1,(100 + (Math.random() * (150 - 100)))); 
      System.out.println("The knight Pick is equipped with " + Pick.weapons.type + ". Its damages are " +Pick.weapons.atk + " It has " + Pick.weapons.acc + " accuracy " + "\n" + "He has " + Pick.health + " Health points" + "\n" + "His speed is " + Pick.speed); 
      return choosePick(); 
      // ^^^ calling recursion 

ソリューション

の内側に閉じ込められています

public static knights choosePick(){ 

      knights Pick = new knights((70 + (Math.random() * (130 - 70))),-1,(100 + (Math.random() * (150 - 100)))); 
      System.out.println("The knight Pick is equipped with " + Pick.weapons.type + ". Its damages are " +Pick.weapons.atk + " It has " + Pick.weapons.acc + " accuracy " + "\n" + "He has " + Pick.health + " Health points" + "\n" + "His speed is " + Pick.speed); 
      return Pick; 
     //   ^^^ return object instead of calling this function again 

Answer 3

あなた knightsクラスで

、方法choosePick、あなたがすべきではないreturn choosePick()しかしreturn Pick;