クラスとして設定された修正配列からランダムな値を生成しますか？

Question

私たちは学校のプロジェクト（学習ゲーム）に取り組んでいます。私たちは「スタック」から値を生成するクラスを使用しています。私たちの問題はスタックの値がなくなった後にゲーム/プログラムがクラッシュして停止することです。

修正値とそのセルに配列を変更して、アドレスするたびにランダムな値を返します。

今のコードはこれです：

using System; 
using System.Collections.Generic; 
using System.Linq; 
using System.Web; 

/// <summary> 
/// Summary description for CellInfoRepository 
/// </summary> 
public class CellProducer 
{ 
    System.Collections.Generic.Stack<Cell> _stack = new Stack<Cell>(); 



    public CellProducer() 
    { 



     _stack.Push(new Cell { InstrumentName = "גיטרה", InstrumentFamily = 1, myPlayer = 0 }); 
     _stack.Push(new Cell { InstrumentName = "עוד", InstrumentFamily = 1, myPlayer = 0 }); 
     _stack.Push(new Cell { InstrumentName = "סיטאר", InstrumentFamily = 1, myPlayer = 0 }); 
     _stack.Push(new Cell { InstrumentName = "כינור", InstrumentFamily = 1, myPlayer = 0 }); 
     _stack.Push(new Cell { InstrumentName = "צ'לו", InstrumentFamily = 1, myPlayer = 0 }); 
     _stack.Push(new Cell { InstrumentName = "ויולה", InstrumentFamily = 1, myPlayer = 0 }); 
     _stack.Push(new Cell { InstrumentName = "נבל", InstrumentFamily = 1, myPlayer = 0 }); 
     _stack.Push(new Cell { InstrumentName = "בנג'ו", InstrumentFamily = 1, myPlayer = 0 }); 
     _stack.Push(new Cell { InstrumentName = "תופים", InstrumentFamily = 2, myPlayer = 0 }); 
     _stack.Push(new Cell { InstrumentName = "מצילה", InstrumentFamily = 2, myPlayer = 0 }); 
     _stack.Push(new Cell { InstrumentName = "שליש", InstrumentFamily = 2, myPlayer = 0 }); 
     _stack.Push(new Cell { InstrumentName = "קסטנייטה", InstrumentFamily = 2, myPlayer = 0 }); 
     _stack.Push(new Cell { InstrumentName = "פעמוניה", InstrumentFamily = 2, myPlayer = 0 }); 
     _stack.Push(new Cell { InstrumentName = "קסילופון", InstrumentFamily = 2, myPlayer = 0 }); 
     _stack.Push(new Cell { InstrumentName = "טמבורין", InstrumentFamily = 2, myPlayer = 0 }); 
     _stack.Push(new Cell { InstrumentName = "פעמוני רוח", InstrumentFamily = 2, myPlayer = 0 }); 
     _stack.Push(new Cell { InstrumentName = "קרן יער", InstrumentFamily = 3, myPlayer = 0 }); 
     _stack.Push(new Cell { InstrumentName = "בריטון", InstrumentFamily = 3, myPlayer = 0 }); 
     _stack.Push(new Cell { InstrumentName = "טרומבון", InstrumentFamily = 3, myPlayer = 0 }); 
     _stack.Push(new Cell { InstrumentName = "טובה", InstrumentFamily = 3, myPlayer = 0 }); 
     _stack.Push(new Cell { InstrumentName = "סקסופון", InstrumentFamily = 3, myPlayer = 0 }); 
     _stack.Push(new Cell { InstrumentName = "חליל", InstrumentFamily = 3, myPlayer = 0 }); 
     _stack.Push(new Cell { InstrumentName = "קלרינט", InstrumentFamily = 3, myPlayer = 0 }); 
     _stack.Push(new Cell { InstrumentName = "משרוקית", InstrumentFamily = 3, myPlayer = 0 }); 
    } 

    public Cell ProduceNextCell() 
    { 
     return _stack.Pop(); 
    } 
} 

私はクラスの名前を保つが、唯一のランダムな値をgeneradeアレイの内部をどのように変化するかを任意のアイデア？

ところで、「セル」は、私たちが作った別のクラスがあり、かつ配列が彼からなされるべきである：ヘブライ語のすべてのノート

using System; 
using System.Collections.Generic; 
using System.Linq; 
using System.Web; 
using System.Web.UI.WebControls; 

/// <summary> 
/// Summary description for Cells 
/// </summary> 
public class Cell:Panel //מחלקת משושים 
{ 
    protected string _instrumentName; //שם כלי הנגינה // 
    protected int _insturmentFamily; //סוג כלי הנגינה - המשפחה // 
    protected int _myPlayer; //ערכים מספריים של 0 - אין שחקן - 1 ו2 לפי השחקנים 

    public string InstrumentName 
    { 
     get 
     { 
      return _instrumentName; 
     } 

     set 
     { 
      _instrumentName = value; 
     } 
    } 

    public int InstrumentFamily 
    { 
     get 
     { 
      return _insturmentFamily; 
     } 

     set 
     { 
      _insturmentFamily = value; 
     } 
    } 

    public int myPlayer 
    { 
     get 
     { 
      return _myPlayer; 
     } 

     set 
     { 
      _myPlayer = value; 
     } 
    } 
} 

public class CellPosition // מחלקה ששומרת את מיקומי התאים 
{ 
    private int _Column; 
    private int _Row; 

    public int Column 
    { 
     get 
     { 
      return _Column; 
     } 

     set 
     { 
      _Column = value; 
     } 
    } 

    public int Row 
    { 
     get 
     { 
      return _Row; 
     } 

     set 
     { 
      _Row = value; 
     } 
    } 
} 

の助けに感謝し、申し訳ありません！

Answer 1

私はそれをテストしていませんが、私はそれが仕事だと思う：

using System; 
using System.Collections.Generic; 
using System.Linq; 
using System.Web; 

/// <summary> 
/// Summary description for CellInfoRepository 
/// </summary> 
public class CellProducer 
{ 
    System.Collections.Generic.List<Cell> cells = new List<Cell>(); 
    Random random = new Random(); 

    public CellProducer() 
    { 
     cells.Add(new Cell { InstrumentName = "גיטרה", InstrumentFamily = 1, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "עוד", InstrumentFamily = 1, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "סיטאר", InstrumentFamily = 1, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "כינור", InstrumentFamily = 1, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "צ'לו", InstrumentFamily = 1, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "ויולה", InstrumentFamily = 1, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "נבל", InstrumentFamily = 1, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "בנג'ו", InstrumentFamily = 1, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "תופים", InstrumentFamily = 2, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "מצילה", InstrumentFamily = 2, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "שליש", InstrumentFamily = 2, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "קסטנייטה", InstrumentFamily = 2, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "פעמוניה", InstrumentFamily = 2, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "קסילופון", InstrumentFamily = 2, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "טמבורין", InstrumentFamily = 2, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "פעמוני רוח", InstrumentFamily = 2, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "קרן יער", InstrumentFamily = 3, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "בריטון", InstrumentFamily = 3, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "טרומבון", InstrumentFamily = 3, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "טובה", InstrumentFamily = 3, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "סקסופון", InstrumentFamily = 3, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "חליל", InstrumentFamily = 3, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "קלרינט", InstrumentFamily = 3, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "משרוקית", InstrumentFamily = 3, myPlayer = 0 }); 
    } 

    public Cell ProduceNextCell() 
    { 
     return cells[random.Next(cells.Count)]; 
    } 
} 

Answer 2

インストゥルメントを格納するために、リストまたは配列を使用できます。その後、0とあなたが持っている要素の数の間のランダムな整数を生成します。

using System; 
using System.Collections.Generic; 
using System.Linq; 
using System.Web; 

/// <summary> 
/// Summary description for CellInfoRepository 
/// </summary> 
public class CellProducer 
{ 
    System.Collections.Generic.List<Cell> cells = new List<Cell>(); 
    int index = -1; 

    public CellProducer() 
    { 
     cells.Add(new Cell { InstrumentName = "?????", InstrumentFamily = 1, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "???", InstrumentFamily = 1, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "?????", InstrumentFamily = 1, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "?????", InstrumentFamily = 1, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "?'??", InstrumentFamily = 1, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "?????", InstrumentFamily = 1, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "???", InstrumentFamily = 1, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "???'?", InstrumentFamily = 1, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "?????", InstrumentFamily = 2, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "?????", InstrumentFamily = 2, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "????", InstrumentFamily = 2, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "????????", InstrumentFamily = 2, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "???????", InstrumentFamily = 2, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "????????", InstrumentFamily = 2, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "???????", InstrumentFamily = 2, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "?????? ???", InstrumentFamily = 2, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "??? ???", InstrumentFamily = 3, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "??????", InstrumentFamily = 3, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "???????", InstrumentFamily = 3, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "????", InstrumentFamily = 3, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "???????", InstrumentFamily = 3, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "????", InstrumentFamily = 3, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "??????", InstrumentFamily = 3, myPlayer = 0 }); 
     cells.Add(new Cell { InstrumentName = "???????", InstrumentFamily = 3, myPlayer = 0 }); 
    } 

    public Cell ProduceNextCell() 
    { 
     index++; 
     if(index>cells.length){ 
      index = 0; 
     return cells[index]; 
    } 
}