ループ/ネステッド・ループの問題はPython 2.7

Question

は週1 player1のために例えば ポイントを獲得43 player2 26 player3 38などなど

その後現在、このプログラムは、最初の選手が得点、再度だけ、すべての5人のプレーヤーへの質問を表示しますもう一度選手質問をし、週2

ために同じことを行います2番目の選手のスコアを表示すると、これは5回繰り返され、選手だけが反復します。

はどこが間違っているつもりです、任意のヘルプは非常にあなたは少し別の関数を使って、どのようにあなたのコール情報を変更する場合、私が思うよう

playerList=[] 
def Playeradd(): 
    playerList.append(item) 
def Playercreate(): 
    global item 
    item = raw_input("Enter Player name: ") 

    Playeradd() 

[Playercreate()for _ in range (5)] 
print "You have selected", len(playerList), "players for your squad, Your selected squad is.." 

for item in playerList: 
    print item 

player =Playercreate 
scorecheck=[] 
x=0 
totalscore=0 
def pointsaward(): 
    global scorecheck, totalscore 
    y=1 
    player=y 
    x=0 
    while x < 5: 
     print "Please enter score for ", playerList[x] 
     for player in playerList: 
      print "Did "+player+" play in the game?" 
      play = raw_input(" Did he play the match (yes or no?) ") 
      if play == "yes": 
       play1=2 
       goalS= int(raw_input(" Did he score, if so how many?")) 
       goalS=goalS*5 
       goalA= int(raw_input(" How many assists?")) 
       goalA=goalA*3 
       motm= raw_input(" Did he win man of the match (yes or no?) ") 
       if motm == "yes": 
        motm1=5 
       else: 
        motm1=0 
       yelC=raw_input(" Did he recieve a yellow card (yes or no?) ") 
       if yelC == "yes": 
        yelC1= -1 
       else: 
        yelC1=0 
       redC=raw_input(" Did he recieve a red card (yes or no?) ") 
       if redC == "yes": 
        redC1= -5 
       else: 
        redC1=0        
       PenM=raw_input(" Did he miss a peno(yes or no?) ") 
       if PenM == "yes": 
        PenM1= -3 
       else: 
        PenM1=0 
      else: 
       play1=0 
       print player+" did not play" 
     playerpoint1= play1+goalS+goalA+yelC1+redC1+PenM1 
     PlayerandScore= [playerList[x],playerpoint1,] 
     scorecheck.append(PlayerandScore) 
     totalscore+= playerpoint1 
     x+= 1 
     y+= 1 
     print "This player has scored a total of ", PlayerandScore, " this week " 
pointsaward() 

Answer 1

[OK]を理解されるであろうと、あなたは、リストの代わりに辞書を使いますこの場合、プレーヤー/スコアの情報を取得するために、コードの変更をよりうまく管理し、データの操作がより簡単になります。

彼女は私がこれまでに得たものです。

playerList=[] 
def Playeradd(): 
    playerList.append(item) 
def Playercreate(): 
    global item 
    item = raw_input("Enter Player name: ") 

    Playeradd() 

[Playercreate()for _ in range (5)] 
print "You have selected", len(playerList), "players for your squad, Your selected squad is.." 

for item in playerList: 
    print item 

player =Playercreate 
scorecheck={} # using a dictionary rather than a list. Because you only have to values to look at this to me seams the best option for displaying data. 
x=0 
totalscore=0 
def pointsaward(): 
    global x, totalscore,scorecheck 
    scorecheck={} 
    while x < 5: 
     print "Please enter score for ", playerList[x] 
     for player in playerList: 
      print "Did "+player+" play in the game?" 
      play = raw_raw_input(" Did he play the match (yes or no?) ") 
      if play == "yes": 
       play1=2 
       goalS= int(raw_input(" Did he score, if so how many?")) 
       goalS=goalS*5 
       goalA= int(raw_input(" How many assists?")) 
       goalA=goalA*3 
       motm= raw_input(" Did he win man of the match (yes or no?) ") 
       motm1=0 
       yelC1=0 
       redC1=0 
       PenM1=0 
       if motm == "yes": 
        motm1=5 #this was missing from the math in total points 
       else: 
        motm1=0 
       yelC=raw_input(" Did he recieve a yellow card (yes or no?) ") 
       if yelC == "yes": 
        yelC1= -1 
       else: 
        yelC1=0 
       redC=raw_input(" Did he recieve a red card (yes or no?) ") 
       if redC == "yes": 
        redC1= -5 
       else: 
        redC1=0        
       PenM=raw_input(" Did he miss a peno(yes or no?) ") 
       if PenM == "yes": 
        PenM1= -3 
       else: 
        PenM1=0 
       playerpoint1= play1+goalS+goalA+yelC1+redC1+PenM1+motm1 
       scorecheck[playerList[x]] = playerpoint1 
       x+= 1 
      else: 
       play1=0 
       scorecheck[playerList[x]] = (player+" did not play") 
       x+= 1 

def printResults(): # added a simple function run the point adding function and print the results. 
    pointsaward() 
    print "This player has scored a total of ", scorecheck, " this week " 
printResults() 

この結果、次のような結果が返されます。注：私は、見ているプレーヤーの数を2に変更して、テストをより速くするようにしました。以下の情報は、2人のプレーヤーを見た場合の結果のみを示しています。

Enter Player name: ads 
Enter Player name: qwe 
You have selected 2 players for your squad, Your selected squad is.. 
ads 
qwe 
Please enter score for ads 
Did ads play in the game? 
Did he play the match (yes or no?) yes 
Did he score, if so how many?5 
How many assists?5 
Did he win man of the match (yes or no?) yes 
Did he recieve a yellow card (yes or no?) no 
Did he recieve a red card (yes or no?) no 
Did he miss a peno(yes or no?) no 
Did qwe play in the game? 
Did he play the match (yes or no?) no 
This player has scored a total of {'ads': 47, 'qwe': 'qwe did not play'} this week