C++ outfileで数値を計算すると問題が発生する

Question

データファイルからの地区投票の結果と内訳を示すテキストファイル出力を作成しようとしています。私は計算するのに適切な数字を得ることに問題があります。投票文書（votes.dat）には、 "District and Y/N"という行に2文字しか含まれていません。なぜ私はエントリがほんの一握り（10未満）のときに4317448と2600960のような数字が出てくるのか分かりません。

#include <string> 
string using namespace std 
#include <iostream> 
#include <fstream> 
#include <iomanip> 

using namespace std; 

int main() 

{ 

ifstream infile; 
ofstream outfile; 
char vote; 
int district; 
int overallTotal; 
int yesTotal; 
int noTotal; 
int d1Yesvotes; 
int d1Novotes; 
int d2Yesvotes; 
int d2Novotes; 
int d3Yesvotes; 
int d3Novotes; 


//open file 

infile.open("votes.dat"); 

infile>>district>>vote; 


//if statement for 'yes' and 'no' votes, containing nested if statements 



if (district=='1') 
    {   
     if(vote=='Y') 
     { 
      yesTotal+1; 
      d1Yesvotes+1; 
      overallTotal+1; } 

    else if(vote=='N') 
    { 
     noTotal+1; 
      d1Novotes+1; 
      overallTotal+1; } 
    } 

    else 
if (district=='2') 
    {   
     if(vote=='Y') 
     {yesTotal+1; 
      d2Yesvotes+1; 
      overallTotal+1;} 

    else if(vote=='N') 
    { noTotal+1; 
      d2Novotes+1; 
      overallTotal+1;} 
     } 
     else 
if (district=='3') 
    {   
     if(vote=='Y') 
     {yesTotal+1; 
      d3Yesvotes+1; 
      overallTotal+1;} 

    else if(vote=='N') 
    { noTotal+1; 
      d3Novotes+1; 
      overallTotal+1;} 

     } 


outfile.open("votingresults.txt"); 
outfile<<endl<<"Number of Overall votes: "<<overallTotal; 
    outfile<<endl; 
outfile<<endl<<"Number of Yes votes: "<<yesTotal; 
outfile<<endl<<"Number of No votes: "<<noTotal; 
    outfile<<endl; 
outfile<<endl<<"Number of District 1 Yes Votes: "<<d1Yesvotes; 
    outfile<<endl<<"Number of District 1 No Votes: "<<d1Yesvotes; 
    outfile<<endl; 
outfile<<endl<<"Number of District 2 Yes Votes: "<<d1Yesvotes; 
    outfile<<endl<<"Number of District 2 No Votes: "<<d1Yesvotes; 
    outfile<<endl; 
outfile<<endl<<"Number of District 3 Yes Votes: "<<d1Yesvotes; 
    outfile<<endl<<"Number of District 3 No Votes: "<<d1Yesvotes; 




//close files 

infile.close(); 
    outfile.close(); 


return 0; 

} 

Answer 1

コードにはいくつか問題があります。 - それはだけにして、コードの1行を読み込み 終了 - あなたは適切

yesTotal+1; 

が効果的にちょうどyesTotal + 1を計算しますが、どこにでもIYを保存していない、あなたの変数をインクリメントされていません。あなたの例では、d1YesVotesを書いていたよう あなたはここで、次の

yesTotal=yesTotal+1; 
yesTotal++; // This does the same thing 

のいずれかを実行する必要がありますが、あなたのコード

#include <string> 
#include <iostream> 
#include <fstream> 
#include <iomanip> 

using namespace std; 

int main() 

{ 

ifstream infile; 
ofstream outfile; 
char vote; 
int district; 
int overallTotal=0; 
int yesTotal=0; 
int noTotal=0; 
int d1Yesvotes=0; 
int d1Novotes=0; 
int d2Yesvotes=0; 
int d2Novotes=0; 
int d3Yesvotes=0; 
int d3Novotes=0; 


//open file 

infile.open("votes.dat"); 


//if statement for 'yes' and 'no' votes, containing nested if statements 
string line; 
if (!infile.is_open()) { 
    cout << "Error opening file" << endl; 
    return 0; 
} 

while (getline(infile, line)) { 
    cout << line << endl; 
    if (line.size() < 2) 
    continue; 
    district=line[0]; 
    vote=line[1]; 
    if (district=='1') 
    {   
    if(vote=='Y') 
    { 
     yesTotal++; 
     d1Yesvotes++; 
     overallTotal++; 
    } 

    else if(vote=='N') 
    { 
     noTotal++; 
     d1Novotes++; 
     overallTotal++; 
    } 
    } 

    else if (district=='2') 
    {   
    if(vote=='Y') 
    { 
     yesTotal++; 
     d2Yesvotes++; 
     overallTotal++; 
    } 

    else if(vote=='N') 
    { 
     noTotal++; 
     d2Novotes++; 
     overallTotal++; 
    } 
    } 
    else if (district=='3') 
    {   
    if(vote=='Y') { 
     yesTotal++; 
     d3Yesvotes++; 
     overallTotal++; 
    } 

    else if(vote=='N') 
    { 
     noTotal++; 
     d3Novotes++; 
     overallTotal++; 
    } 
    } 
} 


outfile.open("votingresults.txt"); 
outfile<<endl<<"Number of Overall votes: "<<overallTotal; 
    outfile<<endl; 
outfile<<endl<<"Number of Yes votes: "<<yesTotal; 
outfile<<endl<<"Number of No votes: "<<noTotal; 
    outfile<<endl; 
outfile<<endl<<"Number of District 1 Yes Votes: "<<d1Yesvotes; 
    outfile<<endl<<"Number of District 1 No Votes: "<<d1Yesvotes; 
    outfile<<endl; 
outfile<<endl<<"Number of District 2 Yes Votes: "<<d2Yesvotes; 
    outfile<<endl<<"Number of District 2 No Votes: "<<d2Yesvotes; 
    outfile<<endl; 
outfile<<endl<<"Number of District 3 Yes Votes: "<<d3Yesvotes; 
    outfile<<endl<<"Number of District 3 No Votes: "<<d3Yesvotes; 




//close files 

infile.close(); 
outfile.close(); 


return 0; 

} 

の修正バージョンである私も、正しいものを使用するように出力変数を変更し、 d1すべての3地区の投票。